Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cart-checkout-validation not working [ checkout completed with error ] #558

Open
xiddixaid opened this issue Sep 18, 2024 · 3 comments
Open

Comments

@xiddixaid
Copy link

Which template or example

cart-checkout-validation

Describe the bug

I am able to complete checkout when there is a validation error

Expected behavior

Checkout button should be disabled when there is validation error on checkout. or should not allow customer to complete checkout when there is validation error implemented through cart-checkout-validation function

Environment

  • Windows
  • Shopify CLI version: 3.63.1
@smshahriar10
Copy link

smshahriar10 commented Oct 5, 2024

@xiddixaid are you sure the order went through successfully even though you saw an error message from your cart-checkout-validation function?

@xiddixaid
Copy link
Author

xiddixaid commented Oct 5, 2024

@xiddixaid are you sure the order went through successfully even though you saw an error message from your cart-checkout-validation function?

A Few days before shopify fixed the issue but only fixed on "Buy it now" button (fixed but showing a strange popup error). But If you proceed to checkout through cart or checkout link it shows customer error but also allow customer to complete checkout.

@jayvin
Copy link

jayvin commented Jan 21, 2025

Noticed the same issue:

  1. One step checkout layout, error message appears and the customer can complete the checkout (not good)
  2. On multi step checkout layout, error message appears and the customer can not complete the checkout (good)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants