Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Origin Validation in webpack-dev-server dependency #3

Open
helenou opened this issue Jan 19, 2019 · 3 comments
Open

Missing Origin Validation in webpack-dev-server dependency #3

helenou opened this issue Jan 19, 2019 · 3 comments

Comments

@helenou
Copy link

helenou commented Jan 19, 2019

Hi, I'm having trouble setting up. I have node v10.15.0 and npm v6.4.1

When i run: npm install
I'm prompted to npm audit fix. I managed to fix webpack-dev-server which was causing problem but then when i try again npm start, I get the following output in console :

{^_^}/ hi!

Loading data/people.json
Done

Resources
http://localhost:3001/posts
http://localhost:3001/comments
http://localhost:3001/profile

Home
http://localhost:3001

Type s + enter at any time to create a snapshot of the database
? We're unable to detect target browsers.

Would you like to add the defaults to your package.json? (Y/n)

And the people json file appears empty when opening localhost:3001

@wolfgangGoedel
Copy link
Contributor

Fixing the vulnerability indeed upgrades react-scripts and requires additional setup. It works if you keep the old version though - but this is not how we want it to be...
...a new version of the course is in the works and will be used next week. You'll get the info on monday.

@helenou
Copy link
Author

helenou commented Jan 21, 2019

Hi, any updates coming today?

@wolfgangGoedel
Copy link
Contributor

update is coming tomorrow - the new repository is public as of now:
https://github.com/Sfeir/sfeirschool-react
in case you want to have an early look ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants