-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haskell #5
base: master
Are you sure you want to change the base?
Haskell #5
Conversation
appConfig = AppConfig { db = "slackbot" | ||
, coll = "testData" | ||
, address = "127.0.0.1" | ||
, token = "m3ABP8zIiY5wzJAtuJcwffji" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think if we have this read from external source i.e env var or file, etc. rather then hard-coded? As this might be a security issue
Why do not we have this PR on top of #3 and not a master (so may be re-create it)? Do you have experience in interactive re-basing? It's super simple with git, but let me know if you need a hand here |
Good idea.
Sorry, my bad. |
Sometimes just re-creating a PR is enough and I think that the case here, just create new PR on top of #3 |
Initial Haskell implementation.
Returns JSON, doesn't use any templates for client-side.
A common client-side app will be in a separate pull-request.