Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haskell #5

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Haskell #5

wants to merge 9 commits into from

Conversation

heruka-urgyen
Copy link
Member

Initial Haskell implementation.
Returns JSON, doesn't use any templates for client-side.
A common client-side app will be in a separate pull-request.

appConfig = AppConfig { db = "slackbot"
, coll = "testData"
, address = "127.0.0.1"
, token = "m3ABP8zIiY5wzJAtuJcwffji" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think if we have this read from external source i.e env var or file, etc. rather then hard-coded? As this might be a security issue

@bzz
Copy link
Member

bzz commented Jan 13, 2015

Why do not we have this PR on top of #3 and not a master (so may be re-create it)?
Also may be it should start with 'initial haskell commit' and does not have anything metheor-related too (even if that's a deletion)

Do you have experience in interactive re-basing? It's super simple with git, but let me know if you need a hand here

@heruka-urgyen
Copy link
Member Author

What do you think if we have this read from external source

Good idea.

Why do not we have this PR on top of #3

Sorry, my bad.
I'll try to rebase it.

@bzz
Copy link
Member

bzz commented Jan 13, 2015

Why do not we have this PR on top of #3

Sorry, my bad.
I'll try to rebase it.

Sometimes just re-creating a PR is enough and I think that the case here, just create new PR on top of #3
Reabse usually referees actually moving commits around and looks like 'initial haskel' is the first one here.. though now I'm not sure who's parent of 'haskel' branch in git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants