Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pin of Lingo version to 3.1.1 because under MW 1.39+ only Lingo 3.2+ works #71

Open
WouterRademaker opened this issue Apr 28, 2023 · 6 comments

Comments

@WouterRademaker
Copy link
Contributor

WouterRademaker commented Apr 28, 2023

Setup and configuration

  • MediaWiki: 1.39.3
  • PHP: 7.4.33 (fpm-fcgi)
  • MariaDB: 10.5.18-MariaDB-0+deb11u1
  • SMW version: 4.1.1
  • SG version: 4.0.0 (dev-master)
  • Lingo version: 3.2.0

Issue

On composer installation of the latest SG version, Lingo links disappear because Lingo is downgraded to 3.1.1. When Lingo is upgraded to 3.2, with git, the Lingo links reappear.

Undo #69 #70 ?

@gesinn-it-gea
Copy link
Member

I think it would be good to have a final release with the pinned version of Lingo so that MW 1.35 users could use that version. Afterwards, a second release with min requirements MW 1.39 could be prepared.

@gesinn-it-gea
Copy link
Member

Unfortunately, SG does not have up-to-date / working CI which makes it harder to manage releases and confirm compatibility with various versions.

@YOUR1
Copy link
Contributor

YOUR1 commented Oct 25, 2023

The whole version/branch structure of this repository has been messed up.

In my opinion;
dev-master should atleast be compatible with the latest LTS release of MediaWiki; and a new 5.0.0 tag should be made specially for Lingo 3.x, MW 1.39 and SMW 4.x...

@WouterRademaker
Copy link
Contributor Author

We are now at:

  • MediaWiki: 1.39.5
  • PHP: 8.1.22 (fpm-fcgi)
  • MariaDB: 10.5.21-MariaDB-0+deb11u1
  • SMW version: 4.1.2
  • SG version: 4.0.0 (dev-master)
  • Lingo version: 3.2.1

dev-master is compatible with the latest LTS release of MediaWiki, so far as we can find.

The problem is what @gesinn-it-gea writes: It is at the moment hard to confirm compatibility with various versions.

@tsadrafoundation
Copy link

I have MW 1.39, php 8.1, Lingo extension on branch REL1_39, but then when installing SemanticGlossary (dev-master) with composer update --no-dev i get:

Warning: Undefined global variable $wgParser in/var/www/html/extensions/Lingo/src/Lingo.php on line53

and this is because Lingo 3.1.1 is installed as a dependency instead of 3.2

@YOUR1
Copy link
Contributor

YOUR1 commented Nov 8, 2024

Fixed in #71 which also implements the glossary-search optimisations made by Lingo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants