Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-safe DataSet Identifier Interface #21

Open
nikolausmoll opened this issue Jun 7, 2013 · 0 comments
Open

Type-safe DataSet Identifier Interface #21

nikolausmoll opened this issue Jun 7, 2013 · 0 comments
Assignees

Comments

@nikolausmoll
Copy link
Contributor

Remove general "Object" return type in IScope, rename class as well. DslIdentifier could be part of type information T

Is:

     public interface IScope
     {

       Object getDataSet();

       String getDslIdentifier();

     }

Should (or similar):

     public interface IScope<T>
     {

       T getDataSet();

     }

Problem:
Both the new Table Builder and the "classic" DataSet must represent the same Scope type (DSL identifer / T).
The class (DSL identifier) of the DataSet is used to distinguish different DSL types. But as the base DataSet class is abstract, the dataset's getClass() method will not return the type of the abstract DataSet class.

@ghost ghost assigned nikolausmoll Jun 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant