Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inverted qr-codes #36

Closed
ao2 opened this issue Jul 9, 2018 · 4 comments
Closed

Support inverted qr-codes #36

ao2 opened this issue Jul 9, 2018 · 4 comments

Comments

@ao2
Copy link

ao2 commented Jul 9, 2018

The app does not recognize inverted qr-codes: those with light foreground color on a dark background.

There is a discussion open about this in the zxing issue tracker, at zxing/zxing#194

Some apps solved the issue by processing the frame twice themselves, like dm77/barcodescanner#265 or freeotp/freeotp-android#192

But I think the library should provide this option itself.

Ciao,
Antonio

@Kamuno
Copy link
Member

Kamuno commented Sep 28, 2019

Thank you for pointing this out. However, we will not include this fix ourselfes. We will update to the newest zxing version is they choose to fix this.

@Kamuno Kamuno closed this as completed Sep 28, 2019
@ao2
Copy link
Author

ao2 commented Sep 28, 2019

Totally understandable, thanks for the reply.

@Kamuno
Copy link
Member

Kamuno commented Dec 16, 2021

If I understand is correctly this should be fixed. We will need to take a look again.

@Kamuno Kamuno reopened this Dec 16, 2021
@Kamuno
Copy link
Member

Kamuno commented Dec 17, 2021

Fixed via 1144caa

@Kamuno Kamuno closed this as completed Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants