Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Relation.insertAll atomic #37

Open
srfc opened this issue May 12, 2018 · 0 comments
Open

Make Relation.insertAll atomic #37

srfc opened this issue May 12, 2018 · 0 comments

Comments

@srfc
Copy link
Collaborator

srfc commented May 12, 2018

Issue

Relation.insertAll is not atomic at the moment. We have opened another issue to add a return type indicating success or failure, but this issue relates to the ability to roll back all singular inserts should one of them fail.

Problem Description

  • If one insert of a Relation.insertAll fails, you get a state of the Relation that is unknown to the developer. The Relation itself should support atomic insertAlls.

Supporting Information

Regarding insertAll, I'm totally fine with also changing its return type to Try[Seq[Record]], but then we should make clear its semantics. I would prefer it to be an atomic operation (this will need some more logic, but should be possible).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant