Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relation and Record definitions allow using ColumnDefs of SAME NAME as long as they're of different TYPE #17

Open
srfc opened this issue May 9, 2018 · 1 comment
Labels
Bug (-fix) Something isn't working (and is addressed in this PR)

Comments

@srfc
Copy link
Collaborator

srfc commented May 9, 2018

Bug Report

Relation and Record definitions allow using ColumnDef's of same name as long as they're of different type.

Expected Behavior

Adding multiple ColumnDef's with the same name to a record should fail at compile-time or runtime.

Actual Behavior

Record(Seq(ColumnDef[Int]("id"), ColumnDef[String]("id")))  // does not fail ever

Steps to Reproduce the Problem

  1. see above

Specifications and Environment

@srfc srfc added the Bug (-fix) Something isn't working (and is addressed in this PR) label May 9, 2018
@SebastianSchmidl SebastianSchmidl added the On Hold Work on this issue or pull request is on hold label May 10, 2018
@SebastianSchmidl SebastianSchmidl removed the On Hold Work on this issue or pull request is on hold label Jul 27, 2018
@SebastianSchmidl
Copy link
Owner

In the mean time we changed our column definitions to be

Record(Set(ColumnDef[Int]("id"), ColumnDef[String]("id")))  // does not fail ever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug (-fix) Something isn't working (and is addressed in this PR)
Projects
None yet
Development

No branches or pull requests

2 participants