-
Notifications
You must be signed in to change notification settings - Fork 2
/
spring-cve-2024-22243_strict.yaml
234 lines (224 loc) · 7.81 KB
/
spring-cve-2024-22243_strict.yaml
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
# Author: Sean Pesce
rules:
# Specific search for direct calls to UriComponentsBuilder.fromUriString, etc. (only works if build() and getHost() are called in the same scope - no taint analysis)
#rules:
- id: cve-2024-22243-uricomponentsbuilder_strict
languages:
- java
options:
interfile: true
patterns:
- pattern-either:
- patterns:
- pattern: $CLAZZ. ... .$FUNC(...). ... .getHost()
- pattern-not: $CLAZZ. ... .$FUNC("..."). ... .getHost()
- patterns:
- pattern: |
(UriComponents $INST) = $CLAZZ. ... .$FUNC(...). ... .build();
...
(UriComponents $INST).getHost();
- pattern-not: |
(UriComponents $INST) = $CLAZZ. ... .$FUNC("..."). ... .build();
...
(UriComponents $INST).getHost();
- patterns:
- pattern: |
$BUILDER = $CLAZZ. ... .$FUNC(...). ... ;
(UriComponents $INST) = ($CLAZZ $BUILDER). ... .build();
...
(UriComponents $INST).getHost();
- pattern-not: |
$BUILDER = $CLAZZ. ... .$FUNC("..."). ... ;
(UriComponents $INST) = ($CLAZZ $BUILDER). ... .build();
...
(UriComponents $INST).getHost();
- metavariable-regex:
metavariable: $CLAZZ
regex: ^(UriComponentsBuilder|ServletUriComponentsBuilder)$
- metavariable-regex:
metavariable: $FUNC
regex: ^(fromUriString|fromHttpUrl)$
message: >-
Potential unsafe use of Spring UriComponentsBuilder (fromUriString/fromHttpUrl), which can cause a host name mismatch (potentially resulting in open redirect or SSRF) for specially-crafted inputs.
severity: WARNING
metadata:
cwe:
- 'CWE-601: URL Redirection to Untrusted Site (Open Redirect)'
- 'CWE-918: Server-Side Request Forgery (SSRF)'
source-rule-url: 'https://spring.io/security/'
references:
- https://spring.io/security/
category: security
technology:
- java
- spring
likelihood: MEDIUM
impact: MEDIUM
confidence: MEDIUM
interfile: true
# Search for calls to UriComponentsBuilder.fromUriString, etc. that sink into UriComponents.getHost (with taint analysis, but cross-file analysis is untested due to being Pro-only)
#rules:
- id: cve-2024-22243-uricomponentsbuilder_taint
languages:
- java
options:
interfile: true
mode: taint
pattern-sources:
- patterns:
- pattern-either:
- patterns:
- pattern-either:
- pattern-inside: |
$METHODNAME(..., @$REQ(...) $TYPE $SOURCE, ...) {
...
}
- pattern-inside: |
$METHODNAME(..., @$REQ $TYPE $SOURCE, ...) {
...
}
- metavariable-regex:
metavariable: $TYPE
regex: ^(?!(Integer|Long|Float|Double|Char|Boolean|int|long|float|double|char|boolean))
- metavariable-regex:
metavariable: $REQ
regex: (RequestBody|PathVariable|RequestParam|RequestHeader|CookieValue|ModelAttribute)
- patterns:
- pattern-either:
- pattern-inside: |
@$ATTR
public $METHODRETTYPE $METHODNAME(..., $TYPE $SOURCE, ...) {
...
}
- pattern-inside: |
@$ATTR(...)
public $METHODRETTYPE $METHODNAME(..., $TYPE $SOURCE, ...) {
...
}
- metavariable-regex:
metavariable: $TYPE
regex: ^(?!(Integer|Long|Float|Double|Char|Boolean|int|long|float|double|char|boolean))
- metavariable-regex:
metavariable: $ATTR
regex: (Request|Delete|Get|Patch|Put|Post)Mapping
- focus-metavariable: $SOURCE
# Unclear whether these are helpful
pattern-propagators:
- pattern: $N = $CLASS. ... .$FUNC(..., $S, ...)
from: $S
to: $N
- pattern: $N = $S. ... .$FUNC(...)
from: $S
to: $N
pattern-sinks:
- patterns:
- pattern-either:
- patterns:
- pattern: $CLASS.$FUNC(...)
- metavariable-regex:
metavariable: $FUNC
regex: ^(fromUriString|fromHttpUrl)$
message: >-
Potential unsafe use of Spring UriComponentsBuilder (fromUriString/fromHttpUrl), which can cause a host name mismatch (potentially resulting in open redirect or SSRF) for specially-crafted inputs.
severity: WARNING
metadata:
cwe:
- 'CWE-601: URL Redirection to Untrusted Site (Open Redirect)'
- 'CWE-918: Server-Side Request Forgery (SSRF)'
source-rule-url: 'https://spring.io/security/'
references:
- https://spring.io/security/
category: security
technology:
- java
- spring
likelihood: MEDIUM
impact: MEDIUM
confidence: MEDIUM
interfile: true
# Search for calls to WebClient and related classes/methods using untrusted Strings (with taint analysis, but cross-file analysis is untested due to being Pro-only)
#rules:
- id: cve-2024-todo-webclient_taint
languages:
- java
options:
interfile: true
mode: taint
pattern-sources:
- patterns:
- pattern-either:
- patterns:
- pattern-either:
- pattern-inside: |
$METHODNAME(..., @$REQ(...) $TYPE $SOURCE, ...) {
...
}
- pattern-inside: |
$METHODNAME(..., @$REQ $TYPE $SOURCE, ...) {
...
}
- metavariable-regex:
metavariable: $TYPE
regex: ^(?!(Integer|Long|Float|Double|Char|Boolean|int|long|float|double|char|boolean))
- metavariable-regex:
metavariable: $REQ
regex: (RequestBody|PathVariable|RequestParam|RequestHeader|CookieValue|ModelAttribute)
- patterns:
- pattern-either:
- pattern-inside: |
@$ATTR
public $METHODRETTYPE $METHODNAME(..., $TYPE $SOURCE, ...) {
...
}
- pattern-inside: |
@$ATTR(...)
public $METHODRETTYPE $METHODNAME(..., $TYPE $SOURCE, ...) {
...
}
- metavariable-regex:
metavariable: $TYPE
regex: ^(?!(Integer|Long|Float|Double|Char|Boolean|int|long|float|double|char|boolean))
- metavariable-regex:
metavariable: $ATTR
regex: (Request|Delete|Get|Patch|Put|Post)Mapping
- focus-metavariable: $SOURCE
# Unclear whether these are helpful
pattern-propagators:
- pattern: $N = $CLASS. ... .$FUNC(..., $S, ...)
from: $S
to: $N
- pattern: $N = $S. ... .$FUNC(...)
from: $S
to: $N
pattern-sinks:
- patterns:
- pattern-either:
- pattern: (WebClient $INST). ... .$SINKFUNC($SINK, ...)
- pattern: (WebClient.Builder $INST). ... .$SINKFUNC($SINK, ...)
- pattern: (WebClient.RequestHeadersUriSpec $INST). ... .$SINKFUNC($SINK, ...)
- pattern: (WebClient.RequestHeadersUriSpec<?> $INST). ... .$SINKFUNC($SINK, ...)
- pattern: (RestClient $INST). ... .$SINKFUNC($SINK, ...)
- pattern: (RestClient.Builder $INST). ... .$SINKFUNC($SINK, ...)
- pattern: (RestClient.RequestHeadersUriSpec $INST). ... .$SINKFUNC($SINK, ...)
- pattern: (RestClient.RequestHeadersUriSpec<?> $INST). ... .$SINKFUNC($SINK, ...)
- metavariable-regex:
metavariable: $SINKFUNC
regex: ^(uri|create|baseUrl)$
# - focus-metavariable: $SINK
message: >-
Potential unsafe use of org.springframework.web.reactive.function.client.WebClient (or RestClient), which can cause a host name mismatch (potentially resulting in SSRF) for specially-crafted inputs.
severity: WARNING
metadata:
cwe:
- 'CWE-918: Server-Side Request Forgery (SSRF)'
source-rule-url: 'https://spring.io/security/'
references:
- https://spring.io/security/
category: security
technology:
- java
- spring
likelihood: MEDIUM
impact: MEDIUM
confidence: MEDIUM
interfile: true