-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TravisCI test to make sure site builds without errors #74
Comments
This is a bit of a shot in the dark, but in my experience, setting up Travis CI initially always is. If this fails CI, having Travis enabled will nonetheless allow iterating in a pull request until CI turns green. Ref SeaGL#74.
Sounds like this is built in to GitHub now:
|
@AndrewKvalheim I think you might be confused about the role that Travis plays and what these Status Checks are. The Status Checks are just indicators. You still need to implement the tests that determine whether the Status Check shows success/failure. This can be done using Travis, but my personal vote would be to use GitHub's newer Actions (https://github.com/features/actions) which avoid us having to setup a new service. Regardless of whether we use Travis or GitHub Actions, we still need to setup a configuration file that specifies the "test" to run. In our case, the test is attempting to build the website. |
Thanks. I took the above to imply that the existing GitHub Pages build service must include pull requests, otherwise the documentation would be misleading. |
If there are no plans to merge a pull request that implements the functionality as specified in the top comment, then perhaps this issue should be closed or respecified. If GitHub Actions really is the desired path forward, then this should be clarified. |
It'd be great to add a test so we know if PRs will break the web site's build.
The text was updated successfully, but these errors were encountered: