Feat/pull from vault setup #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzaloetjo
force-pushed
the
feat/pull-from-vault
branch
from
da320cc to
6fb54be
Compare
gonzaloetjo
force-pushed
the
feat/pull-from-vault
branch
from
6fb54be to
66a2767
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Fixes #81
Additional comments
initiatePullFundsFromVaultvariable to potentially setpullFundsFromVaulttotrueduring deployment as needed.pullFundsFromVaultvia thesetPullFundsFromVaultfunction for the rolesMULTISIG_ROLEandSTRATEGIST_MULTISIG_ROLEedit: i guess this won't work in previous deployments, as establishing capabilities will fail for those deployments that don't have the setPullFundsFromVault function.