Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategist could use DexAggregatorUManager, or DexSwapperUManager and still be able to extract value from the BoringVault #16

Open
crispymangoes opened this issue Mar 27, 2024 · 1 comment

Comments

@crispymangoes
Copy link
Collaborator

Issue

The aforementioned micro managers perform value in vs value out checks on UniswapV3 and 1inch swaps. Even with these checks, the strategist could perform multiple swaps that barely pass the slippage check, in order to extract a larger amount of value over time.

Fix

The micro managers make this attack vector substantially messier, but not impossible. One possible solution would be to make the slippage requirements even stricter. Another one would be to add some rate limiting logic in the micro manager to prevent the strategist from swapping excessively.

The issue with both of the solutions above is they severely constrain the strategist to the point where I worry that they would not be able to take appropriate actions during a black swan event. Now we could implement one or both of these fixes, but then have separate micro managers, or just have a more trusted strategist multisig be able to perform swap actions without micro managers.

@Saraeutsza
Copy link

#16 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants