Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

# sign in .env #37

Closed
gtramontina opened this issue Mar 28, 2014 · 3 comments · May be fixed by ScoutGroup/node-foreman#3
Closed

# sign in .env #37

gtramontina opened this issue Mar 28, 2014 · 3 comments · May be fixed by ScoutGroup/node-foreman#3

Comments

@gtramontina
Copy link

I have a password I use for development and I put it into the .env file. The problem I'm facing is that the password has the # character and node-foreman is considering it a comment. I also tried wrapping it into single quotes, as one would do in the shell, but I got even weirder results.

It seems like a somewhat easy fix, but I'm kinda short on time to get my head down and submit a PR.
@rmg
Copy link
Member

rmg commented Mar 28, 2014

@gtramontina is writing your .env file in JSON an option? I'm not sure if it is supported by any of the other Foreman clones, but it is supported by node-foreman.

rmg added a commit that referenced this issue Mar 28, 2014
@rmg
test: Failing test for # handling in .env
7995101 
Reproduced the bug reported in #37
@rmg rmg closed this as completed in cc14b50 Mar 28, 2014
@rmg
Copy link
Member

rmg commented Mar 28, 2014

Fixed it for the non-JSON format and released v0.1.2.

@gtramontina
Copy link
Author

Great! I sure can have my .env file in json.
Thanks for the quick follow up!

@snyk-bot snyk-bot mentioned this issue Oct 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade shell-quote from 1.4.3 to 1.7.2 ScoutGroup/node-foreman
2 participants
@rmg @gtramontina