-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLVUU-102 simplify getApplicationLayout response #120
SLVUU-102 simplify getApplicationLayout response #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes look good. Just need to change the target branch to main.
This might just be me, but I don't like the 256 commits showing up. You could tidy this up by doing a soft reset to main, then committing the resulting changes and force pushing. |
a11a0b2
to
7660aba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor observations.
...-server/src/main/java/org/finos/vuu/layoutserver/controller/ApplicationLayoutController.java
Outdated
Show resolved
Hide resolved
...ver/src/test/java/org/finos/vuu/layoutserver/controller/ApplicationLayoutControllerTest.java
Outdated
Show resolved
Hide resolved
...ut-server/src/test/java/org/finos/vuu/layoutserver/service/ApplicationLayoutServiceTest.java
Show resolved
Hide resolved
…LVUU-102-simplify-get-application-layout-contract
…LVUU-102-simplify-get-application-layout-contract
Changes