Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLVUU-102 simplify getApplicationLayout response #120

Conversation

vferraro-scottlogic
Copy link

Changes

  • GET /application-layout to return JSONLayout type (omit username)
  • Delete ApplicationLayoutDTO (server side)
  • Delete ApplicationLayout type (client side)

Copy link

@pling-scottlogic pling-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes look good. Just need to change the target branch to main.

@vferraro-scottlogic vferraro-scottlogic changed the base branch from VUU333-layout-server to main November 22, 2023 10:19
@pling-scottlogic
Copy link

This might just be me, but I don't like the 256 commits showing up. You could tidy this up by doing a soft reset to main, then committing the resulting changes and force pushing.

@vferraro-scottlogic vferraro-scottlogic force-pushed the SLVUU-102-simplify-get-application-layout-contract branch from a11a0b2 to 7660aba Compare November 27, 2023 09:56
Copy link

@cfisher-scottlogic cfisher-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor observations.

@pling-scottlogic pling-scottlogic self-requested a review November 28, 2023 12:14
…LVUU-102-simplify-get-application-layout-contract
…LVUU-102-simplify-get-application-layout-contract
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify data contract for getting application layouts
3 participants