Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare and document exact differences between Token & Timelock compared to Alpha Interfaces #5

Open
apbendi opened this issue Jul 7, 2023 · 1 comment

Comments

@apbendi
Copy link
Member

apbendi commented Jul 7, 2023

We should use cast to generate the interfaces for the POOL token and Timelock and compare them to the expected interfaces in the OZ contracts, documenting all differences and the impact they will have. This might require us to vendor in customized versions of the OZ contracts to support the ABI differences compared to a standard Governor Alpha deployment.

First identified by @alexkeating here and here.

@alexkeating
Copy link
Contributor

The only spot I see the token being used here which the POOL token supports.

This may be an unwarranted worry, but are we worried that there could be future issues because the interface is to fully compatible with the actual token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants