Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolic tracing in staggered grid can return Nans #352

Open
cmhyett opened this issue Jan 13, 2024 · 0 comments · May be fixed by #353
Open

Symbolic tracing in staggered grid can return Nans #352

cmhyett opened this issue Jan 13, 2024 · 0 comments · May be fixed by #353
Labels
bug Something isn't working

Comments

@cmhyett
Copy link
Contributor

cmhyett commented Jan 13, 2024

The way tracing was implemented in staggered_discretize.jl zeros were padded to dynamic variables to ensure we didn't get two copies of the update when performing the split step integration. Unfortunately this is not at all the right way to do this. It is not correct if we have inhomogeneous terms and can return Inf if we divide by the variable.

@cmhyett cmhyett added the bug Something isn't working label Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant