Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check for breakdown if adaptive=false #185

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DanielVandH
Copy link
Member

This changes phiv_timestep to no longer check for a happy-breakdown if adaptive=false.

Checklist

  • Appropriate tests were added

I'm not sure what example to come up with to get a new direct test for this. The only example I have is from private code.

  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

@DanielVandH
Copy link
Member Author

Actually this seems to lead to a regression in #143 since, without checking for breakdown, that example takes an extremely long time since the default is adaptive=false. Is there a better solution for this? Maybe checking that adaptive=true and simultaneously tau wasn't specified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant