Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use generated function implimentation of naivemul for sparse matrices #175

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

oscardssmith
Copy link
Contributor

@oscardssmith oscardssmith commented May 31, 2024

I'm in general pretty skeptical of the naivemul introduced in #57, but this at least makes it dramatically better for sparse matrices. This improves, but does not fix SciML/OrdinaryDiffEq.jl#2121.

# before
julia> @time exponential!(sprand(500,500,.001), ExpMethodGeneric());
  9.914123 seconds (52 allocations: 13.983 MiB)

#after
@time exponential!(sprand(500,500,.001), ExpMethodGeneric());
  2.100566 seconds (260 allocations: 14.785 MiB)

@ChrisRackauckas ChrisRackauckas merged commit 4e5be62 into SciML:master Jun 3, 2024
16 of 28 checks passed
@oscardssmith oscardssmith deleted the os/sparse-naivemul branch June 3, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance regression in non-autonomous Linear ODE solvers
2 participants