From e3b1676c03579f57c94a9874646d4ac33b66e658 Mon Sep 17 00:00:00 2001 From: Anant Thazhemadam <47104651+thazhemadam@users.noreply.github.com> Date: Mon, 8 Apr 2024 18:13:56 +0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- src/kiops.jl | 2 +- src/krylov_phiv_adaptive.jl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/kiops.jl b/src/kiops.jl index 335327e..29c7eaf 100644 --- a/src/kiops.jl +++ b/src/kiops.jl @@ -48,7 +48,7 @@ References: - Niesen, J. and Wright, W.M., 2012. Algorithm 919: A Krylov subspace algorithm for evaluating the ``φ``-functions appearing in exponential integrators. ACM Transactions on Mathematical Software (TOMS), 38(3), p.22 """ function kiops(tau_out, -A, u; mmin::Int = 10, mmax::Int = 128, m::Int = min(mmin, mmax), + A, u; mmin::Int = 10, mmax::Int = 128, m::Int = min(mmin, mmax), tol::Real = 1e-7, opnorm = LinearAlgebra.opnorm(A, Inf), iop::Int = 2, ishermitian::Bool = LinearAlgebra.ishermitian(A), task1::Bool = false) n, ppo = size(u, 1), size(u, 2) diff --git a/src/krylov_phiv_adaptive.jl b/src/krylov_phiv_adaptive.jl index a981472..9ab8787 100644 --- a/src/krylov_phiv_adaptive.jl +++ b/src/krylov_phiv_adaptive.jl @@ -31,7 +31,7 @@ intuitive interface (vector `b` instead of a n-by-1 matrix `B`). arXiv:0907.4631. """ function expv_timestep(ts::Vector{tType}, -A, b; kwargs...) where {tType <: Real} + A, b; kwargs...) where {tType <: Real} U = similar(b, size(A, 1), length(ts)) expv_timestep!(U, ts, A, b; kwargs...) end