Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final release 2.0.0 #57

Closed
13 tasks done
mxochicale opened this issue May 31, 2023 · 6 comments
Closed
13 tasks done

Final release 2.0.0 #57

mxochicale opened this issue May 31, 2023 · 6 comments
Assignees
Labels
p1-high High priority

Comments

@mxochicale
Copy link
Contributor

mxochicale commented May 31, 2023

I am opening this issue to plan final release 2.0.0 from the release candidate v2.0rc0 https://pypi.org/project/scikit-surgeryutils/2.0rc0/

git tag -a 'v2.0.0' -m "Release version v2.0.0"
git push origin v2.0.0

Thanks

@mxochicale mxochicale self-assigned this May 31, 2023
@mxochicale mxochicale added the p1-high High priority label May 31, 2023
@mxochicale
Copy link
Contributor Author

mxochicale commented Jun 13, 2023

local tox logs

FAILED tests/test_sksurgeryarucotest.py::test_sksurgeryarucotest - AttributeError: module 'cv2.aruco' has no attribute 'Dictionary_get'

SOLUTION: https://stackoverflow.com/questions/74964527/attributeerror-module-cv2-aruco-has-no-attribute-dictionary-get

Tried package versions

mxochicale added a commit that referenced this issue Jun 13, 2023
@mxochicale
Copy link
Contributor Author

  • conflicts with package versions

https://github.com/SciKit-Surgery/scikit-surgeryutils/actions/runs/5253786647/jobs/9491551217

The conflict is caused by:
    The user requested opencv-contrib-python-headless>=4.7.0.72
    scikit-surgeryvtk 2.0.0 depends on opencv-contrib-python-headless>=4.7.0.72
    scikit-surgeryimage 0.10.1 depends on opencv-contrib-python-headless>=4.2.0.32
    scikit-surgeryarucotracker 0.2.8 depends on opencv-contrib-python-headless<4.7

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

mxochicale added a commit that referenced this issue Jun 13, 2023
@thompson318
Copy link
Collaborator

scikit-surgeryarucotracker >= 1.0.0 should fix this also. I'm not sure why surgeryutils is pulling in such an old version of arucotracker

@mxochicale
Copy link
Contributor Author

Removing package version for "opencv-contrib-python-headless" and "scikit-surgeryarucotracker" fix installation of requirements in python3.8 for ubuntu-latest and macos-latest but not for windows-latest and others python versions: https://github.com/SciKit-Surgery/scikit-surgeryutils/actions/runs/5255757370

mxochicale added a commit that referenced this issue Jun 13, 2023
…: AttributeError: module cv2.aruco has no attribute Dictionary_get (#57)
mxochicale added a commit that referenced this issue Jun 13, 2023
…: AttributeError: module cv2.aruco has no attribute Dictionary_get (#57)
mxochicale added a commit that referenced this issue Jun 14, 2023
…eError: module cv2.aruco has no attribute Dictionary_get (#57)
mxochicale added a commit that referenced this issue Jun 14, 2023
mxochicale added a commit that referenced this issue Jun 14, 2023
…e cv2.aruco has no attribute Dictionary_get (#57)
mxochicale added a commit that referenced this issue Jun 14, 2023
…odule cv2.aruco has no attribute Dictionary_get (#57)
mxochicale added a commit that referenced this issue Jun 14, 2023
… AttributeError: module cv2.aruco has no attribute Dictionary_get (#57)
@mxochicale
Copy link
Contributor Author

E AttributeError: module 'cv2.aruco' has no attribute 'Dictionary_get'

🔴 Trying to remotely use both opencv-python and opencv-contrib-python-headless but don't fix the issue
https://github.com/SciKit-Surgery/scikit-surgeryutils/actions/runs/5265407978/jobs/9517990501#step:6:850

🔴 Trying to remotely use opencv-contrib-python only but don't fix it > https://github.com/SciKit-Surgery/scikit-surgeryutils/actions/runs/5265593578/jobs/9518429427#step:6:858

🔴 Trying to remotely use both opencv-python and opencv-contrib-python but don't fix the issue
https://github.com/SciKit-Surgery/scikit-surgeryutils/actions/runs/5265666785/jobs/9518605336#step:6:852

mxochicale added a commit that referenced this issue Jun 14, 2023
…eError: module cv2.aruco has no attribute Dictionary_get (#57)
mxochicale added a commit that referenced this issue Jun 20, 2023
mxochicale added a commit that referenced this issue Jun 20, 2023
…: AttributeError: module cv2.aruco has no attribute Dictionary_get (#57)
mxochicale added a commit that referenced this issue Jun 20, 2023
…: AttributeError: module cv2.aruco has no attribute Dictionary_get (#57)
mxochicale added a commit that referenced this issue Jun 21, 2023
mxochicale added a commit that referenced this issue Jun 21, 2023
mxochicale added a commit that referenced this issue Jun 21, 2023
…akecalibrationdots.rst, sksurgeryrendermodelslikecamera.rst, sksurgeryreslice.rst, sksurgerytextoverlay.rst (#57)
@mxochicale
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-high High priority
Projects
None yet
Development

No branches or pull requests

2 participants