-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import video_calibration and video_calibration_checker apps from scikit-surgerycalibration.py #46
Comments
Would anyone like to review code on branch 46-use-headless? In order to use opencv-headless, I had to import videocalibration_app and videocalibrationchecker_app from scikit-surgerycalibration, and then re-write the UI to use PySide (VTKOverlayWindow). So, its not worth doing a diff with master ... as the 4 main files are a complete re-write. so, please can someone just look at:
I also made the decision that things that are static config should be in the config file, and things that you might change on the fly, and hence would not want to git commit, are command line args, e.g. opencv source, interactive mode etc. Overall, I'm happy with the result, unit tests pass, linting passes, but of course, happy for suggestions. |
Looks good to me thank you. It only seems to be passing on python 3.7 at the moment. Is that intentional? |
No description provided.
The text was updated successfully, but these errors were encountered: