Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a model for the scicat "Proposal" #140

Open
bpedersen2 opened this issue Sep 18, 2023 · 3 comments
Open

Add a model for the scicat "Proposal" #140

bpedersen2 opened this issue Sep 18, 2023 · 3 comments

Comments

@bpedersen2
Copy link

Most scicat models are implemented, but Proposal seems to be missing.

This would be handy for implementing proposal ingesters and for getting e.g. the abstract of the proposal.

@jl-wynen
Copy link
Collaborator

The model is one thing. But we would also need functions to call the endpoints.

I'm not entirely sure yet what the scope of Scitacean is. I did not plan for it to cover the whole API but instead focus on the most commonly used (by non-experts) operations. What would be the benefit for you to handle proposals with Scitacean instead of PySciCat?

@bpedersen2
Copy link
Author

I dont have any problem using pyscicat, so this can be kept a low priority.

@jl-wynen
Copy link
Collaborator

I had a quick stab at it. Adding the model to the generator and writing the functions to call the endpoints is easy. But the proposal models have fields with non standard naming schemes:

  • pi_email, pi_firstname, pi_lastname
  • MeasurementPeriodList

They cause problems for the automated name translation because that assumes camelCase and breaks for snake_case and PascalCase. This can be fixed but probably needs special case handling for proposals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants