Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for arrays in scientificMetadata #924

Closed
jkotan opened this issue Nov 30, 2023 · 3 comments · May be fixed by #925
Closed

add support for arrays in scientificMetadata #924

jkotan opened this issue Nov 30, 2023 · 3 comments · May be fixed by #925
Labels
meeting Discuss in meeting before merge

Comments

@jkotan
Copy link
Contributor

jkotan commented Nov 30, 2023

Summary

At DESY we often store some parts of scientificMetadata in arrays/lists e.g. vectors

"vector": {
    "value": [1,1,0],
    "unit": "mm"
}

However, I such case the current algorithm to convert value and units to SI crashes.

Expected Behaviour

I would like to support also arrays/lists in scientificMetadata as well.
@jkotan jkotan mentioned this issue Nov 30, 2023
Open
@nitrosx
Copy link
Contributor

nitrosx commented Dec 1, 2023

@jkotan thank you so much for the PR.
Interesting enough, one of our instrument scientist just mention this exact feature.
I will review the PR soon.

@sbliven
Copy link
Contributor

sbliven commented Dec 6, 2023

Isn't this a bug in the frontend display of arrays? I think we have arrays in some of our datasets, but we just display scientificMetadata as a JSON object without any restrictions or parsing.

@nitrosx nitrosx added the meeting Discuss in meeting before merge label Dec 7, 2023
@bpedersen2 bpedersen2 mentioned this issue Dec 8, 2023
Closed
@nitrosx nitrosx mentioned this issue Jan 2, 2024
Open
@nitrosx
Copy link
Contributor

nitrosx commented Jan 2, 2024

Opened issue #984 with a proposed comprehensive solution that integrates the one proposed in this issue.

@nitrosx nitrosx closed this as completed Jan 2, 2024
@nitrosx nitrosx mentioned this issue Jan 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meeting Discuss in meeting before merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 924: add support for arrays in scientificMetadata jkotan/scicat-backend-next
3 participants
@sbliven @nitrosx @jkotan