You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SciCat should have an appropriate default job configuration.
Current Behaviour
The job configuration file is read from the JOB_CONFIGURATION_FILE. It currently defaults to (src/config/configuration.ts:47):
const jobConfigurationFile =
process.env.JOB_CONFIGURATION_FILE ||
("src/jobs/config/jobConfig.example.json" as string);
This was convenient for development, but should now be set to a secure final value.
Expected Behaviour
I would say that the default behavior when JOB_CONFIGURATION_FILE is unset should be to look for "jobConfig.json" in the current directory. This mirrors the location for functionalAccounts.json. If the file is not found it should be treated as an empty config, eg
{
"configVersion": "",
"jobs": []
}
If #1120 is implemented then Scicat checks for ./jobConfig.{json,yaml,yml} and uses the first one found.
If JOB_CONFIGURATION_FILE is set then it is loaded. An error should be thrown if the file is not found.
The text was updated successfully, but these errors were encountered:
Appropriate default for JOB_CONFIGURATION_FILE
Summary
SciCat should have an appropriate default job configuration.
Current Behaviour
The job configuration file is read from the JOB_CONFIGURATION_FILE. It currently defaults to (src/config/configuration.ts:47):
This was convenient for development, but should now be set to a secure final value.
Expected Behaviour
I would say that the default behavior when JOB_CONFIGURATION_FILE is unset should be to look for
"jobConfig.json"
in the current directory. This mirrors the location forfunctionalAccounts.json
. If the file is not found it should be treated as an empty config, egIf #1120 is implemented then Scicat checks for
./jobConfig.{json,yaml,yml}
and uses the first one found.If JOB_CONFIGURATION_FILE is set then it is loaded. An error should be thrown if the file is not found.
The text was updated successfully, but these errors were encountered: