You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is cleaning Dataset State in dataset-details-dashboard.component.ts necessary?
Summary
I am creating a new component on top of the existing dataset model for Swiss OpenEm project. I want to be routed there from the /datasets/:id and I implemented a button that routes my new component (to /datasets:id/mycomp)in the datasets-details. My component needs the information about this dataset. As I understand, /dataset/:id view in the frontend consists of two components: the datasets-details-dashboard which is followed by datasets-details. In the former, commands are implemented to clear the state of Dataset, Sample, and Proposal, like this in the ngOnDestroy(): this.store.dispatch(clearCurrentDatasetStateAction());.
When my button is rerouting me this is triggered so I lose information about my Dataset.
Is there any specific reason why we need to clear these states? I looked through the frontend repo and other components don't do anything like that. Also, I don't understand why we clear the states of Samples and Proposals when they have a separate dashboard component.
I would appreciate any input!
Steps to Reproduce
adding a route to somewhere like /datasets/:id/route
Current Behaviour
No information about dataset with that PID
Expected Behaviour
keeping the Dataset information
The text was updated successfully, but these errors were encountered:
Issue Name
Is cleaning Dataset State in
dataset-details-dashboard.component.ts
necessary?Summary
I am creating a new component on top of the existing dataset model for Swiss OpenEm project. I want to be routed there from the
/datasets/:id
and I implemented a button that routes my new component (to/datasets:id/mycomp
)in thedatasets-details
. My component needs the information about this dataset. As I understand,/dataset/:id
view in the frontend consists of two components: thedatasets-details-dashboard
which is followed bydatasets-details
. In the former, commands are implemented to clear the state of Dataset, Sample, and Proposal, like this in thengOnDestroy()
:this.store.dispatch(clearCurrentDatasetStateAction());
.When my button is rerouting me this is triggered so I lose information about my Dataset.
Is there any specific reason why we need to clear these states? I looked through the frontend repo and other components don't do anything like that. Also, I don't understand why we clear the states of Samples and Proposals when they have a separate dashboard component.
I would appreciate any input!
Steps to Reproduce
adding a route to somewhere like
/datasets/:id/route
Current Behaviour
No information about dataset with that PID
Expected Behaviour
keeping the Dataset information
The text was updated successfully, but these errors were encountered: