chore: sonarcloud quality gate fixes (#60)

SchweizerischeBundesbahnen · Oct 29, 2024 · 7dd8747 · 7dd8747
1 parent 03bce69
commit 7dd8747
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/main/java/ch/sbb/polarion/extension/excel_importer/service/ImportService.java b/src/main/java/ch/sbb/polarion/extension/excel_importer/service/ImportService.java
@@ -137,7 +137,7 @@ private void fillWorkItemFields(IWorkItem workItem, Map<String, Object> mappingR
     boolean ensureValidValue(String fieldId, Object value, Set<FieldMetadata> fieldMetadataSet) {
         FieldMetadata fieldMetadata = getFieldMetadataForField(fieldMetadataSet, fieldId);
         if (FieldType.BOOLEAN.getType().equals(fieldMetadata.getType()) &&
-                (!(value instanceof String) || !("true".equalsIgnoreCase((String) value) || "false".equalsIgnoreCase((String) value)))) {
+                (!(value instanceof String stringValue) || !("true".equalsIgnoreCase(stringValue) || "false".equalsIgnoreCase(stringValue)))) {
             throw new IllegalArgumentException(String.format("'%s' isn't a valid boolean value", value == null ? "" : value));
         }
         return true;

diff --git a/...java/ch/sbb/polarion/extension/excel_importer/settings/ExcelSheetMappingSettingsTest.java b/...java/ch/sbb/polarion/extension/excel_importer/settings/ExcelSheetMappingSettingsTest.java
@@ -48,8 +48,9 @@ void testSettingDoesNotExist() {
             ExcelSheetMappingSettingsModel model = excelSheetMappingSettings.defaultValues();
             model.setBundleTimestamp("default");
 
+            SettingId settingId = SettingId.fromName("Any setting name");
             assertThrows(ObjectNotFoundException.class, () -> {
-                ExcelSheetMappingSettingsModel loadedModel = excelSheetMappingSettings.load(projectName, SettingId.fromName("Any setting name"));
+                excelSheetMappingSettings.load(projectName, settingId);
             });
         }
     }