Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot override default baseClass and thumbClass #37

Open
mzellho opened this issue Apr 27, 2016 · 0 comments
Open

Cannot override default baseClass and thumbClass #37

mzellho opened this issue Apr 27, 2016 · 0 comments

Comments

@mzellho
Copy link

mzellho commented Apr 27, 2016

I'm afraid, there is no way to override default settings for baseClass and thumbClass in setScopeValues().

Maybe I am just being blind but I think the scope of the directive should offer to accept thumbClass and baseClass from HTML, e.g:

...
scope: {
                images: '=',
                thumbsNum: '@',
                baseClass: '@',
                thumbClass: '@',
                hideOverflow: '='
            }
...

<ng-gallery data-images="images" data-base-class="customBaseClass" data-thumb-class="customThumbClass" data-thumbs-num="images.length"></ng-gallery>

PR: #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant