Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support migration of ODJ #2451

Open
mj-hof opened this issue Jan 8, 2025 · 0 comments
Open

Support migration of ODJ #2451

mj-hof opened this issue Jan 8, 2025 · 0 comments
Assignees
@larsrickert
Labels
cooperation Issues for projects in cooperative mode dev Requires technical expertise
Milestone
Product improvements

Comments

@mj-hof
Copy link
Collaborator

mj-hof commented Jan 8, 2025 •
edited by larsrickert
Loading

For the ODJ, the following onyx features need to be implemented:

  • Data grid: Support custom cell content (Implement Cell Render #2370)
  • Table / data grid: Support slots for headline, actions and pagination (Implement Header labels #2496)
  • Input: Support custom content for message/tooltip (for adding a link)
  • form elements message: should we support multiline truncation? Or maybe even default to multiline truncation instead of ellipsis. Answer: no
  • breadcrumb component
  • tag: support removing, e.g. with "x" icon
  • headline: support visualSize property
@mj-hof mj-hof added this to onyx Jan 8, 2025
@mj-hof mj-hof converted this from a draft issue Jan 8, 2025
@mj-hof mj-hof added the dev Requires technical expertise label Jan 8, 2025
@mj-hof mj-hof added this to the Product improvements milestone Jan 8, 2025
@larsrickert larsrickert added the cooperation Issues for projects in cooperative mode label Jan 8, 2025
@larsrickert larsrickert moved this from Ready to In Progress in onyx Jan 14, 2025
@mj-hof mj-hof moved this from In Progress to Ready in onyx Jan 22, 2025
@larsrickert larsrickert mentioned this issue Jan 23, 2025
Merged
4 tasks
@larsrickert larsrickert moved this from Ready to In Progress in onyx Jan 23, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 23, 2025
@larsrickert @github-actions
feat(OnyxHeadline): support showAs property (#2587)
8664d21 
Relates to #2451 

Add new `showAs` property to allow defining a different visual size
instead of the semantical type.

## Checklist

- [x] The added / edited code has been documented with
[JSDoc](https://jsdoc.app/about-getting-started)
- [x] All changes are documented in the documentation app (folder
`apps/docs`)
- [x] If a new component is added, at least one [Playwright screenshot
test](https://github.com/SchwarzIT/onyx/actions/workflows/playwright-screenshots.yml)
is added
- [x] A changeset is added with `npx changeset add` if your changes
should be released as npm package (because they affect the library
usage)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
JoCa96 pushed a commit that referenced this issue Jan 30, 2025
@larsrickert @github-actions @JoCa96
feat(OnyxHeadline): support showAs property (#2587)
89e536b 
Relates to #2451 

Add new `showAs` property to allow defining a different visual size
instead of the semantical type.

## Checklist

- [x] The added / edited code has been documented with
[JSDoc](https://jsdoc.app/about-getting-started)
- [x] All changes are documented in the documentation app (folder
`apps/docs`)
- [x] If a new component is added, at least one [Playwright screenshot
test](https://github.com/SchwarzIT/onyx/actions/workflows/playwright-screenshots.yml)
is added
- [x] A changeset is added with `npx changeset add` if your changes
should be released as npm package (because they affect the library
usage)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larsrickert larsrickert

Labels
cooperation Issues for projects in cooperative mode dev Requires technical expertise
Projects
onyx
Status: In Progress
Milestone
Product improvements
Development

No branches or pull requests
2 participants
@larsrickert @mj-hof