Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement OnyxDrawer #2285

Open
12 tasks
Tracked by #2067
JoCa96 opened this issue Dec 9, 2024 · 0 comments
Open
12 tasks
Tracked by #2067

Implement OnyxDrawer #2285

JoCa96 opened this issue Dec 9, 2024 · 0 comments
Labels
dev Requires technical expertise

Comments

@JoCa96
Copy link
Collaborator

JoCa96 commented Dec 9, 2024

Why?

A drawer is used by the OnyxShortcutLegend.

Open questions / TODOs

Depends on

Design

Figma

Image

Acceptance criteria

Implementation details

<-- Add technical details / implementation proposals if necessary, e.g.:

  • API proposal
  • relevant web APIs
  • learnings from other implementations
  • code snippets
    -->

Reference implementations

Applicable ARIA Pattern

Definition of Done

  • The following component requirements are implemented:

    • skeleton
    • density
    • example usage added to apps/demo-app/src/views/HomeView.vue

  • Should be covered by tests:

    • functional tests (Playwright or unit test)
    • visual tests (Playwright screenshots)

  • Make sure, that

    • follow-up tickets were created if necessary
    • updated version + documentation is deployed
    • Storybook can show the feature
    • Storybook code snippet of new/changed examples are checked that they are generated correctly
    • Namings are aligned with Figma

Approval

Storybook
Documentation

  • Checked and approved by
    • designer
    • dev
@JoCa96 JoCa96 added the dev Requires technical expertise label Dec 9, 2024
@JoCa96 JoCa96 added this to onyx Dec 9, 2024
@github-project-automation github-project-automation bot moved this to New in onyx Dec 9, 2024
@JoCa96 JoCa96 mentioned this issue Dec 9, 2024
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev Requires technical expertise
Projects
onyx
Status: New
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoCa96