Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement stable OnyxFormElement layout #2234

Open
11 tasks
JoCa96 opened this issue Dec 4, 2024 · 0 comments
Open
11 tasks

Implement stable OnyxFormElement layout #2234

JoCa96 opened this issue Dec 4, 2024 · 0 comments
Assignees
Labels
dev Requires technical expertise

Comments

@JoCa96
Copy link
Collaborator

JoCa96 commented Dec 4, 2024

Why?

Currently, there is a layout shift happening when a FormElement switches from no message to any (error, info, normal) message.

There is a discussion ongoing if space for the message should be reserved for displaying a message (in particular an error message) or if additional whitespace should be avoided.

Reserving space:

  • visual stability
  • better accessibility
  • consistent layout

Dynamic height:

  • cleaner initial layout
  • uses less space
  • more UX freedom

As with the label and its hideLabel property, there should be an equivalent hideMessage property.
We can consider adding an extra property to toggle a slim/inline/no-label-and-message/only-textbox-mode.

Therefore, we will reserve the space by default. Only when explicitly hidden, the space is removed.

Design

Figma

Acceptance criteria

  • FormElement

Implementation details

Reference implementations

Applicable ARIA Pattern

Definition of Done

  • The following component requirements are implemented:

    • skeleton
    • density
    • example usage added to apps/demo-app/src/views/HomeView.vue
  • Should be covered by tests:

    • functional tests (Playwright or unit test)
    • visual tests (Playwright screenshots)
  • Make sure, that

    • follow-up tickets were created if necessary
    • updated version + documentation is deployed
    • Storybook can show the feature
    • Storybook code snippet of new/changed examples are checked that they are generated correctly
    • Namings are aligned with Figma

Approval

Storybook Documentation - [ ] Checked and approved by designer - [ ] Checked and approved by dev

@JoCa96 JoCa96 added the dev Requires technical expertise label Dec 4, 2024
@JoCa96 JoCa96 added this to onyx Dec 4, 2024
@github-project-automation github-project-automation bot moved this to New in onyx Dec 4, 2024
@JoCa96 JoCa96 self-assigned this Dec 4, 2024
@JoCa96 JoCa96 removed the status in onyx Dec 4, 2024
@JoCa96 JoCa96 moved this to New in onyx Dec 4, 2024
@JoCa96 JoCa96 moved this from New to Backlog in onyx Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Requires technical expertise
Projects
Status: Backlog
Development

No branches or pull requests

1 participant