Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Figma variable import to not convert opacity to rem #2229

Open
larsrickert opened this issue Dec 4, 2024 · 1 comment
Open

Fix Figma variable import to not convert opacity to rem #2229

larsrickert opened this issue Dec 4, 2024 · 1 comment
Assignees
@larsrickert
Labels
bug Something isn't working or not shown correctly dev Requires technical expertise
Milestone
Product improvements

Comments

@larsrickert
Copy link
Collaborator

larsrickert commented Dec 4, 2024 •
edited
Loading

Follow up on #2054

Currently, our Figma variable import workflow converts all numeric values to rem which also includes newly added opacity tokens.

However, opacity in CSS must be unit less so we should find a generic way how to not convert those variables to rem but still convert all others.

#2218 (comment)
@larsrickert larsrickert added this to onyx Dec 4, 2024
@larsrickert larsrickert self-assigned this Dec 4, 2024
@larsrickert larsrickert moved this to In Progress in onyx Dec 4, 2024
@larsrickert larsrickert added bug Something isn't working or not shown correctly dev Requires technical expertise labels Dec 4, 2024
@larsrickert larsrickert moved this from In Progress to Ready in onyx Dec 4, 2024
@larsrickert larsrickert mentioned this issue Dec 4, 2024
Closed
9 tasks
@larsrickert
Copy link
Collaborator Author

larsrickert commented Dec 4, 2024 •
edited
Loading

Node: We are currently not using those opacity tokens in DEV

@mj-hof mj-hof added this to the Product improvements milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larsrickert larsrickert

Labels
bug Something isn't working or not shown correctly dev Requires technical expertise
Projects
onyx
Status: Ready
Milestone
Product improvements
Development

No branches or pull requests
2 participants
@larsrickert @mj-hof