Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

118 integrate configs for self service content and feature flags #123

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

118 integrate configs for self service content and feature flags #123

wants to merge 1 commit into from

Conversation

esteban-gs
Copy link
Member

@esteban-gs esteban-gs commented Nov 7, 2022 •
edited
Loading

Changes:

  • Replaced ConfigsService with AppSettingsStore. Cached configs prevent unnecessary http requests & so it can be used globally.
  • Applied changes to tests and components consuming the removed ConfigsService
  • Replaced some static text with their dynamic parts from AppSettingsStore

Release Consideration:

  • For all tenants using the online orders, we need to add the static test to their production db, so they don't loose the text.
  • The plain text will remain visible in this PR

@esteban-gs esteban-gs linked an issue Nov 7, 2022 that may be closed by this pull request
Integrate Configs for self-service content and feature flags #118
Open
@jcii jcii force-pushed the 118-integrate-configs-for-self-service-content-and-feature-flags branch 2 times, most recently from 34894ae to 27d48d3 Compare November 19, 2022 21:33
@esteban-gs esteban-gs force-pushed the 118-integrate-configs-for-self-service-content-and-feature-flags branch 2 times, most recently from 39886b4 to 4f0cd9d Compare November 19, 2022 22:05
@jcii jcii force-pushed the 118-integrate-configs-for-self-service-content-and-feature-flags branch from 4f0cd9d to 47d3bf1 Compare November 19, 2022 22:55
@esteban-gs esteban-gs force-pushed the 118-integrate-configs-for-self-service-content-and-feature-flags branch 2 times, most recently from 22b812e to 59f27da Compare November 19, 2022 23:18
@esteban-gs esteban-gs force-pushed the 118-integrate-configs-for-self-service-content-and-feature-flags branch from 59f27da to 25b1d39 Compare June 17, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate Configs for self-service content and feature flags
1 participant
@esteban-gs