Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In 4.2 polydisperse hollow_cylinder @S(Q) fails (Trac #1258) #283

Open
RichardHeenan opened this issue Mar 30, 2019 · 3 comments
Open

In 4.2 polydisperse hollow_cylinder @S(Q) fails (Trac #1258) #283

RichardHeenan opened this issue Mar 30, 2019 · 3 comments

Comments

@RichardHeenan
Copy link
Contributor

In 4.2 hollow_cylinder fails if have both an S(Q) and polydispersity.

''File "sas\sascalc\data_util\calcthread.pyc", line 274, in _run
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()''

This is one of the two special models, along with vesicle - see also #1280 - where shell not total volume provides the scaling.

In 5.0 there is NOT an extra volume parameter, so this fail does not occur, but we still need to look at the scaling of the model.

Migrated from http://trac.sasview.org/ticket/1258

{
    "status": "new",
    "changetime": "2019-03-27T08:50:43",
    "_ts": "2019-03-27 08:50:43.207193+00:00",
    "description": "\nIn 4.2 hollow_cylinder fails if have both an S(Q) and polydispersity.\n\n''File \"sas\\sascalc\\data_util\\calcthread.pyc\", line 274, in _run\nValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()''\n\nThis is one of the two special models, along with vesicle - see also #1257 - where shell not total volume provides the scaling.\n\n\n\nIn 5.0 there is NOT an extra volume parameter, so this fail does not occur, but we still need to look at the scaling of the model.",
    "reporter": "richardh",
    "cc": "richardh",
    "resolution": "",
    "workpackage": "SasModels Model Issues",
    "time": "2019-03-26T10:01:47",
    "component": "SasView",
    "summary": "In 4.2 polydisperse hollow_cylinder @S(Q) fails",
    "priority": "minor",
    "keywords": "",
    "milestone": "SasView 4.3.0",
    "owner": "pkienzle",
    "type": "defect"
}
@sasview-bot
Copy link

Trac update at 2019/03/26 11:02:14: yunliu commented:

For the scaling issue, a new ticket (http://trac.sasview.org/ticket/1259) is created.
Even though the scaling issue was only tested for sphere and vesicle with the hard sphere interaction this time, it is useful to check if this is a generic problem for many other models.

@pkienzle
Copy link
Contributor

Trac update at 2019/03/27 01:09:32: pkienzle commented:

Cannot reproduce. Please provide parameters that fail.

@RichardHeenan
Copy link
Contributor Author

Trac update at 2019/03/27 08:50:43: richardh commented:

Replying to [comment:2 pkienzle]:

Cannot reproduce. Please provide parameters that fail.

running e.g. release 4.2.1 on windows 10, seen this on two different laptops, used default params for hollow_cylinder, add hard sphere, turn on polydispersity, set pd_radius to 0.1

However my developer build of 4.2 master does not do this, so suspect that either some more recent change has actually already fixed this problem or it is specifically a problem with the release build??

@ricleal ricleal transferred this issue from SasView/sasview Apr 23, 2019
@pkienzle pkienzle added this to the sasmodels Next Release +1 milestone Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants