Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overflow of widgets on Home screen #68

Open
mortal-ghost opened this issue Dec 8, 2021 · 8 comments · May be fixed by #137
Open

Overflow of widgets on Home screen #68

mortal-ghost opened this issue Dec 8, 2021 · 8 comments · May be fixed by #137
Assignees
@noman2002
Labels
CodePeak good first issue Good for newcomers SWoC ui/ux Editing the UI/UX

Comments

@mortal-ghost
Copy link
Contributor

Description

Some widgets on the home screen overflow by some pixels. This occurs on 1080p and 720p screen resolution devices and does not occur on 1440p devices (tested on only these resolutions).

Relevant files

lib/Screens/Home.dart

Screenshot

Screenshot_1638961295
@Saransh-cpp Saransh-cpp added good first issue Good for newcomers ui/ux Editing the UI/UX labels Dec 8, 2021
@raviyadav17
Copy link
Contributor

Can i work on this issue??
Name : Ravi

@Saransh-cpp
Copy link
Owner

Yes, go ahead!

@raviyadav17 raviyadav17 mentioned this issue Dec 10, 2021
Closed
6 tasks
@mortal-ghost
Copy link
Contributor Author

Hi this may be a separate issue than this one but the home screen does not work for landscape mode. I tried it on 1080p resolution.

@raviyadav17
Copy link
Contributor

raviyadav17 commented Dec 12, 2021 •
edited
Loading

Hi this may be a separate issue than this one but the home screen does not work for landscape mode. I tried it on 1080p resolution.

Thanks for pointing it out i will look into it.
Can you tell on which device you tested that.

@Saransh-cpp
Copy link
Owner

Hi this may be a separate issue than this one but the home screen does not work for landscape mode. I tried it on 1080p resolution.

This would be a new feature request, you can create a new issue.

@raviyadav17 raviyadav17 mentioned this issue Dec 13, 2021
Closed
@raviyadav17
Copy link
Contributor

@Saransh-cpp can you now see and tell me about why merging is not working

This was referenced Dec 15, 2021
Closed
Closed
Closed
Closed
Merged
raviyadav17 added a commit to raviyadav17/BookRentApp-Chapter3 that referenced this issue Dec 18, 2021
@raviyadav17
Merge pull request #2 from raviyadav17/Fixed-Home.dart
75c95aa 
Fixed Home.dart (Issue Saransh-cpp#68)
This was referenced Dec 18, 2021
Closed
Closed
@Saransh-cpp Saransh-cpp mentioned this issue Jan 6, 2022
Closed
@Saransh-cpp
Copy link
Owner

@noman2002, you can take up this issue!

@noman2002
Copy link
Contributor

Please assign it to me

@noman2002, you can take up this issue!

@noman2002 noman2002 linked a pull request Jan 8, 2022 that will close this issue
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noman2002 noman2002

Labels
CodePeak good first issue Good for newcomers SWoC ui/ux Editing the UI/UX
Projects
None yet
Milestone
No milestone
4 participants
@noman2002 @Saransh-cpp @mortal-ghost @raviyadav17