I don't think we have a proper system for a in game deck yet, the system you mentioned under Proposed Solution I think uses Resources which I don't think is a good solution for decks that change over the course of the game. So unless there is a deck system I'm not aware of I think it would be better to wait with this pr and maybe make a new pr regarding decks and building of the deck

The default deck is a resource, and it only contains an array of cards. When starting the game, the array of card is copied into the current deck, it's an array.
Adding and removing cards then just comes to adding and removing things from an array. I think we have the tools for this PR already

Is the current deck an array in the playermanager? in that case it's probably fine, is there anything else to discuss here?

It's an array of card in the CardManager: var current_deck: Array[CardBase] = []

For other things to discuss, adding and removing cards from the deck. I'm guessing a simple push_front() to add and erase() to delete would work (removes the first occurrence so we don't delete multiple values)

Should probably have some simple helper functions in CardManager like Add_card, and remove_card, but other than that it seems fine

Yes, helpers to remove torches already exist, but I don't think we have helpers for the inventory apart from that 🤔
So adding those would probably be part of the issue here too

Regarding, the price increasing for card removal, do we have a good place to track that. I assume most shop scripts wil be instanced when you come to the shop scene, so I don't think we can track them in any of those scripts unless we use static variables, but I don't think that's a good idea cause it might be a bit bug prone. Probably just somewhere in the player or card manager would be good

We can even create a new ShopManager, though it would only be used to track the price increase of card removal;
But it would be clear where to go search for that, and it could be used for other stuff next

Ye, that seems like a good idea. We also need a good way to chose which card is removed, should we just do a system simmilar to slay the spire, we already have a way to display the deck, so we should be able to use that to chose a card to remove

I'm wondering if we could re-use the card display but the cards are buttons and you can change the action depending on where you come click to view the deck.
So if you are just viewing it, button does nothing. If you arrived on this screen by clicking on card removal, then the button is active and can be used to remove the card you click on. Probably a good idea to make a little screen display to ask for confirmation also.

Yeah, that was the solution I was thinking, I'm not sure if they already are buttons or if we need to change them, and if we do need to change them, should be do it in this issue or should we make a new one, since this is kind of unrelated to the main issue

I would consider card removal as part of the shop, so it would make sense to do it now

For how the player buys items, I propose we make a Shop_Item script which has a price value and when it is clicked on by the player, and the player can afford it, the Shop_Item script sends a signal which another class uses to play animations/ give players items. The reason I want shop_item in it's own script is so that we can easly add diffrent kind of items to buy, as well as reuse the code. What do you think of this solution?

That seems like a good idea. Initalized as a child of the shop scene ?

For the positions of the items in the shop, I would say we define a few sets of positions depending on the number of items / cards / consumables ?

Like a 3/4/3 or a 2/4/2 for example ? Or even if we don't define several, at least a system that allows adding new sets of positions in the future ?

Yeah, what I was thinking was just having arrays for shop_items for each item type, like a item_shop_item array, a card_shop_items, and consumable_shop_item. Then I'd just connect them in the scene where we could position them how we want.

What i was saying was that we have some predefined positions for certain number of items, but yes we'll probably have items in arrays in the shop.
A question that we didn't talk about, how do we choose which cards / consumable / items get displayed in a given shop ?

It should probably be random, but should we have the same card throughout the run or wil they change depending on floor? We should probably at least have some poools of the diffrent items which the shop can pull from. This is all very heavily dependent on game balance so I sugest we have something modular like, but I also don't think we need anything more than an array of the options. For consumables we can also have the amount of conumables in the same array so we can change that

mmh i would say we start with making the shop interface before trying more elaborate things for the actual stuff to put into the shop
yes it should be modular, we can start with a simple array of options though