Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MR descriptor list #1117

Merged
merged 7 commits into from
May 15, 2024
Merged

MR descriptor list #1117

merged 7 commits into from
May 15, 2024

Conversation

wrrobin
Copy link
Collaborator

@wrrobin wrrobin commented Apr 5, 2024

No description provided.

@wrrobin wrrobin force-pushed the pr/fix-hmem-verbs branch from f67706d to 4317631 Compare April 30, 2024 21:17
@wrrobin wrrobin requested a review from davidozog May 1, 2024 18:13
@wrrobin wrrobin changed the title External heap MR descriptor for HMEM MR descriptor list May 1, 2024
Copy link
Member

@davidozog davidozog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wrrobin, do you happen to know how the MR descriptors are traversed by the provider? For example, if there is a list of 3 descriptors and the target is in the external heap, are all 3 MR descriptors read to lookup which applies? Could there be a performance cost associated with that?

src/transport_ofi.h Show resolved Hide resolved
@wrrobin
Copy link
Collaborator Author

wrrobin commented May 1, 2024

@wrrobin, do you happen to know how the MR descriptors are traversed by the provider? For example, if there is a list of 3 descriptors and the target is in the external heap, are all 3 MR descriptors read to lookup which applies? Could there be a performance cost associated with that?

Great question. And, I do not know what order it is traversed. Let me ask this question and add you to that email thread.

@wrrobin wrrobin force-pushed the pr/fix-hmem-verbs branch from 8a26143 to 769e5df Compare May 3, 2024 14:07
wrrobin added 4 commits May 3, 2024 10:11
External heap mrfd for fetch atomic

Removed external mrfd from fetch_atomic

Using atomic_nbi for fetch_nbi

Clean up

Added mr-descs for both atomic operations

Trial check for backtrace

Trial check removing mrfd for error case

Trial check#2 removing mrfd for error case

Trial check#3 removing mrfd for error case

Trial check#4 removing mrfd for error case

Trial check#5 removing mrfd for error case

Trial with sockets provider
@wrrobin wrrobin force-pushed the pr/fix-hmem-verbs branch from 359dabb to 9e280fb Compare May 3, 2024 17:11
@wrrobin wrrobin requested a review from rithwiktom May 7, 2024 20:01
@wrrobin
Copy link
Collaborator Author

wrrobin commented May 15, 2024

@rithwiktom - Could you get a chance to test this out on your end?

Copy link
Collaborator

@rithwiktom rithwiktom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works on ORPRE.

@wrrobin wrrobin merged commit 934f44a into Sandia-OpenSHMEM:main May 15, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants