feature: Add multirail support and optional usage of hwloc for optimal NIC assignment #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipmarshall21
force-pushed
the
multirail_with_hwloc
branch
3 times, most recently
from
6796126 to
0b52547
Compare
davidozog
reviewed
Jan 9, 2024
philipmarshall21
force-pushed
the
multirail_with_hwloc
branch
from
2f5c521 to
175e917
Compare
…ld cannot be found
philipmarshall21
force-pushed
the
multirail_with_hwloc
branch
from
175e917 to
d331a77
Compare
|
@wrrobin @markbrown314 @parkerha1 Just wanted to give a little reminder that this branch is ready for review when you have the cycles to give it a look :) |
davidozog
reviewed
Apr 3, 2024
src/transport_ofi.c
Outdated
| if (NULL == info->p_info) { | ||
| RAISE_WARN_MSG("OFI transport, no valid fabric (prov=%s, fabric=%s, domain=%s)\n", | ||
| info->prov_name != NULL ? info->prov_name : "<auto>", | ||
| info->fabric_name != NULL ? info->fabric_name : "<auto>", | ||
| info->domain_name != NULL ? info->domain_name : "<auto>"); | ||
| return ret; | ||
| } | ||
| DEBUG_MSG("provider: %s\n", info->p_info->domain_attr->name); |
There was a problem hiding this comment.
I believe this is included in the DEBUG_MSG below, can we remove it here?
davidozog
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for utilizing multiple NICs to increase peak RMA bandwidth. Additionally, it adds support for use of hwloc to optimally assign processes to a NIC based on each process' CPU affinity.