Skip to content

Commit

Permalink
Fix for atomicv on CXI (#1147)
Browse files Browse the repository at this point in the history
* Fix for atomicv on CXI

* Removing periodic quiet
  • Loading branch information
wrrobin authored Sep 19, 2024
1 parent 1584b4e commit 34b5727
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
7 changes: 1 addition & 6 deletions src/shmem_comm.h
Original file line number Diff line number Diff line change
Expand Up @@ -336,12 +336,7 @@ shmem_internal_atomicv(shmem_ctx_t ctx, void *target, const void *source,
shmem_internal_fetch_atomic(ctx, ((uint8_t *) target) + (i * type_size),
((uint8_t *) source) + (i * type_size), &tmp_fetch, type_size,
pe, op, datatype);
#ifdef SOS_OFI_CXI_QUIET_RATE
/* FIXME: This intermittent quiet should not be required: */
if (i % SOS_OFI_CXI_QUIET_RATE == 0) {
shmem_transport_put_quiet((shmem_transport_ctx_t *)ctx);
}
#endif
shmem_transport_get_wait((shmem_transport_ctx_t *)ctx);
}
*completion += 1;
#else
Expand Down
7 changes: 0 additions & 7 deletions src/transport_ofi.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,6 @@
#define ENABLE_TARGET_CNTR 0
#endif

#if DISABLE_NONFETCH_AMO
/* FIXME: The progress of back-to-back atomic ops over CXI is improved with an
* occasional quiet operation. This constant sets the number of atomic ops that
* occur between calls to quiet within shmem_internal_atomicv. */
#define SOS_OFI_CXI_QUIET_RATE 200
#endif

#if ENABLE_TARGET_CNTR
extern struct fid_cntr* shmem_transport_ofi_target_cntrfd;
#endif
Expand Down

0 comments on commit 34b5727

Please sign in to comment.