Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement relaxed simd operations on ARM-64 #296

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

zherczeg
Copy link
Collaborator

Added a commit which enables test to see they pass on CI. Will be removed since ARM-32 support is not present.

@zherczeg zherczeg force-pushed the relaxed_arm64 branch 2 times, most recently from 80f6a8e to fa6691f Compare October 21, 2024 11:28
@zherczeg
Copy link
Collaborator Author

It looks like the owner of the docker files started many changes and it cause fails now:
https://github.com/uraimo/run-on-arch-action/commits/master/

I will try to figure out what to do.

@@ -158,7 +158,7 @@ jobs:
with:
submodules: true
- name: Build in arm32 container
uses: uraimo/run-on-arch-action@v2.7.2
uses: uraimo/run-on-arch-action@master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New version 2.8.1 has been released just few hours ago (https://github.com/marketplace/actions/run-on-architecture).
What about using the latest version instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the idea. It is working.

Copy link
Collaborator

@clover2123 clover2123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clover2123 clover2123 merged commit 28ce56c into Samsung:main Oct 22, 2024
14 checks passed
@zherczeg zherczeg deleted the relaxed_arm64 branch October 22, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants