Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two instances of Chrome launch when debugging against the emulator #110

Open
NeoPhi opened this issue Sep 12, 2022 · 0 comments
Open

Two instances of Chrome launch when debugging against the emulator #110

NeoPhi opened this issue Sep 12, 2022 · 0 comments

Comments

@NeoPhi
Copy link

NeoPhi commented Sep 12, 2022

The launchDebugMode function in appLaunchHelper.js checks to see if deviceIpAddress === EMULATOR_IP. At which point it calls setPortForward which launches an instance of Chrome. However after setPortForward returns another instance of Chrome is launched within launchDebugMode. It is unclear why the launch is needed within setPortForward since the debugIP is remapped to local host.

I wanted to confirm the intent before submitting a PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NeoPhi