Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of filtering TreeView may not be performant #58

Open
samamstar opened this issue Dec 20, 2022 · 0 comments
Open

Implementation of filtering TreeView may not be performant #58

samamstar opened this issue Dec 20, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@samamstar
Copy link
Contributor

Current approach is to just collapse all widgets that don't match the filter, with the exception of parents that have a child that match, and vice versa.

Possible issue could arise where all objects in a view could end up getting displayed, since none of them match the filter. In a large data set this could cause significant performance issues.

For now; I'm leaving this on the backburner. If it becomes an issue in the future, here are some possible approaches:

  • Stop returning children that don't match the filter in function "On_TreeWidget_BP_OnGetItemChildren_0" in LIB_WT_TreeView
    • may cause issues when filter is removed; will need to refresh list view in that case
  • Don't bother with checks when test string gets more complex and we've already decided an object doesn't match
  • Remove top-level objects that don't match
    • will likely cause similar issues to "Stop returning children" approach
@samamstar samamstar added the enhancement New feature or request label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant