Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MenuItemComponent for Lyche #710

Merged
merged 20 commits into from
Feb 10, 2024

Conversation

amaliejvik
Copy link
Contributor

Create MenuItemComponent.
Create Route from Lychee start page to Lyche menu page
#705

@amaliejvik amaliejvik self-assigned this Oct 3, 2023
@amaliejvik amaliejvik linked an issue Oct 3, 2023 that may be closed by this pull request
Line in LycheMenuPage.tsx too long. Add enter on line.
@amaliejvik amaliejvik force-pushed the 705-create-lyche-menuitem-component branch from 6743c95 to a67656a Compare October 10, 2023 17:21
@amaliejvik amaliejvik force-pushed the 705-create-lyche-menuitem-component branch from a67656a to f9441f4 Compare October 10, 2023 17:27
@amaliejvik amaliejvik requested a review from Mathias-a as a code owner October 31, 2023 18:04
@amaliejvik amaliejvik requested a review from emilte October 31, 2023 19:14
frontend/src/AppRoutes.tsx Outdated Show resolved Hide resolved
Copy link
Member

@robines robines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se kommentarer

@magsyg
Copy link
Contributor

magsyg commented Dec 18, 2023

Ooopsi ser ut som godkjente en som branchet ut av denne, fixer disse feilene

@magsyg magsyg requested a review from robines December 18, 2023 12:31
@magsyg magsyg force-pushed the 705-create-lyche-menuitem-component branch from 140f11c to bef6ed8 Compare December 18, 2023 12:35
@emilte
Copy link
Member

emilte commented Dec 18, 2023

@magsyg Ikke force push

@robines
Copy link
Member

robines commented Feb 1, 2024

@amaliejvik Denne ser bra ut, bare å fikse conflict og så merge

@magsyg magsyg merged commit f0592f7 into master Feb 10, 2024
5 checks passed
@magsyg magsyg deleted the 705-create-lyche-menuitem-component branch February 10, 2024 01:29
@robines
Copy link
Member

robines commented Feb 10, 2024

@magsyg Ikke merge andre folks PRer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Lyche MenuItem component
5 participants