Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File size ADLB #661

Closed
martingebel opened this issue Mar 8, 2022 · 11 comments
Closed

File size ADLB #661

martingebel opened this issue Mar 8, 2022 · 11 comments
Assignees
Labels
question Further information is requested

Comments

@martingebel
Copy link

Dear All,

the tool actually looks amazing. Great work!

Therefore, I tried to use it for a 800 patient study. Eve n though I restricted the lab data set to only the relevant variables (8) and measurements (5) I always get the error message "maximum upload size exceeded".

Is it possible to increase the allowed file size?

Thanks in advance

@jwildfire jwildfire added ques question Further information is requested labels Mar 8, 2022
@jwildfire jwildfire self-assigned this Mar 8, 2022
@jwildfire jwildfire removed the ques label Mar 8, 2022
@jwildfire
Copy link
Contributor

Hey @martingebel - Thanks for the kind words!

Yeah, there's an option called shiny.maxRequestSize that sets that limit - default is 5mb, IIRC. You can update that option for your session, or if you're using safetyGraphicsInit() to load files, we've added a parameter that updates it for you: safetyGraphicsInit(maxFileSize=100) #increases max file size to 100mb

You can also get around the limit by passing your data directly to the safetyGraphicsApp() function as shown in this example.

If that doesn't work, feel free to add more detail or upload a screenshot of your error and I can try to dig deeper with you.

@martingebel
Copy link
Author

martingebel commented Mar 9, 2022

Great, upload works smoothly now . Thanks a lot for covering this so quickly.

Nevertheless, I am only able use the lb chart when just uploading the ADLB. When I additionally upload ADSL I receive error messages and the app is in a greyed out mode I would call it
error

Also receiving error messages when just uploading ADSL (whichever variable I use as Treatment group) and trying to start the demographics table...
Data set requirements should be fulfilled, since quite low on ADSL anyhow
error

@jwildfire
Copy link
Contributor

jwildfire commented Mar 9, 2022

Yeah, the 2nd error is a known bug that has been fixed and will be included in the upcoming v2.1 release on CRAN. For now, you can try installing the newest version of the safetyCharts dependency from GitHub as a work around: devtools::install_github('safetygraphics\safetyCharts', ref='dev')

Not sure what is going on with the first error block. Are you using the safetyGraphicsInit() process? That part of the app hasn't had tons of testing, so it's entirely possible you've found a new issue ...

@martingebel
Copy link
Author

You are right, loading the data into R using the safetyGraphics::safetyGraphicsApp(domainData=list(labs=Labs,dm=adsl)) it works fine. So, it seems that the safetyGraphicsInit() function is causing the issue when using two of my data sets.

Also the updated version from Github solved my second error. Thanks

@jwildfire
Copy link
Contributor

Good deal, @martingebel. Going to go ahead and close out this issue. Don't hesitate to reach out with more questions/feedback.

@paulinebaur
Copy link

Dear All,

just like @martingebel, I tried to use safetyGraphicsInit() (with safetyGraphics version 2.1.0) and I ran into the same error message (arguments imply differing number of rows: 1,0). I encountered this error with some of my own data as well as after saving safetyData::adam_adlbc, safetyData::adam_adae and safetyData::adam_adsl as .csv files and uploading these files to safetyGraphicsInit().

Although everything works perfectly using the command safetyGraphicsApp(), I would prefer working with safetyGraphicsInit(), since it gives researchers, who don’t use R the chance to upload and analyze their data.

Therefore, I wanted to ask, if you know a workaround around this error or have some ideas for me on how to solve my problem.

Thanks for your help in advance!

@jwildfire
Copy link
Contributor

Hi @pauline - thanks for the message. We'll look in to this using the test data and try to re-create and figure out what's going on.

@samussiah - feel free to jump in if you've got time later this week.

@jwildfire jwildfire reopened this May 3, 2022
@samussiah
Copy link
Contributor

This issue might be related to the server delay that's already implemented. Increasing delayTime to 2000 seems to resolve the error. Will investigate further.

@jwildfire
Copy link
Contributor

Interesting, kind of forgot about that hack that I put in to get it to render consistently.

@paulinebaur could you try starting the app with safetyGraphicsInit(delayTime=5000) and see if that helps. This tells the app to wait for 5 seconds (instead of the default 1 second) before rendering. If that workaround does the trick, we can try to dig in and find a more permanent fix as time allows.

@paulinebaur
Copy link

Thank you for your answers. Indeed increasing the delayTime helps and safetyGraphicsInit() works just fine now. Thanks a lot!

@jwildfire
Copy link
Contributor

Thanks @paulinebaur and @samussiah - closing this out. I just filed #671 to take a longer look at this as time allows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants