Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECG ADaM data domains for QT #8

Open
xni7 opened this issue Oct 6, 2021 · 3 comments
Open

Add ECG ADaM data domains for QT #8

xni7 opened this issue Oct 6, 2021 · 3 comments
Assignees
Milestone

Comments

@xni7
Copy link

xni7 commented Oct 6, 2021

@jwildfire , there are some public ADaM data domains for the QT topic.

see https://physionet.org/content/ecgcipa/1.0.0/. The ADEG data look very useful sample data for the QT visualizations https://physionet.org/content/ecgcipa/1.0.0/adeg.csv

@jwildfire jwildfire added this to the v1.1.0 milestone Oct 6, 2021
@jwildfire jwildfire self-assigned this Oct 6, 2021
@jwildfire
Copy link
Contributor

@xni7 Since the files are so large, I wonder if we should just put in a little "import_ecg()" function that calls read_csv() on the existing URLs and saves the data in your session (or alternatevely on disc). We'd roll right past the 5mb limit in CRAN otherwise.

@xni7
Copy link
Author

xni7 commented Oct 6, 2021

I think it's definitely one option, @jwildfire . The risk might be the source url could be unreachable if the server is down, or the data is taken offline. I couldn't reach CTSpedia now to fetch Rich's QT sample data there. One option might be to download and host somewhere such as Github, and point to it. Another option might be to trim down the data by rows and/or columns. It's more work, and if we are already close to the 5mb mark, it may be difficult even if we trim

@jwildfire
Copy link
Contributor

Good point. Maybe we can put the data in the repo under /dataraw but add it to rbuildignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants