Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for grouping column in hep-explorer #99

Open
jwildfire opened this issue Mar 11, 2022 · 3 comments
Open

Add support for grouping column in hep-explorer #99

jwildfire opened this issue Mar 11, 2022 · 3 comments

Comments

@jwildfire
Copy link
Contributor

Per SafetyGraphics/safetyGraphics#662. Relevant in some other renderers as well.

@jwildfire
Copy link
Contributor Author

See #100 and associated PR for an implementation outside of safetyGraphics

@jwildfire
Copy link
Contributor Author

jwildfire commented Mar 20, 2022

Fix is pretty straightforward, just need to make a custom init that merges in the treatment column from dm and maps it to settings.group_col.

Would be nice to avoid having to do this for every chart though ... Maybe safetyGraphics could provide standardized access to certain key mappings (group_col, filters, etc). Will think about if there's a straightforward way to implement that ...

@jwildfire
Copy link
Contributor Author

jwildfire commented Mar 9, 2023

@samussiah I wonder if it would be easy to add a helper function that does this for multiple charts in the new modular htmlwidget framework you've set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant