Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially add settings$baseline_values to create_nepexplorer_app #138

Open
pburnsdata opened this issue Feb 26, 2024 · 1 comment · Fixed by #144
Open

Potentially add settings$baseline_values to create_nepexplorer_app #138

pburnsdata opened this issue Feb 26, 2024 · 1 comment · Fixed by #144
Assignees
@Lovemore-Gakava
Milestone
v1.0.0

Comments

@pburnsdata
Copy link
Contributor

pburnsdata commented Feb 26, 2024 •
edited
Loading

not sure if needed or not - right now i dont see it in if is.null default settings

add here:

nepExplorer/R/create_nepexplorer_app.R

Line 42 in 9bbcd83

"baseline_flag" = "BLFL",

@pburnsdata pburnsdata mentioned this issue Feb 26, 2024
Merged
@Lovemore-Gakava
Copy link
Contributor

Thanks Preston - this will be added in the next round of updates.

@pburnsdata pburnsdata added this to the v1.0.0 milestone Apr 19, 2024
@pburnsdata pburnsdata mentioned this issue Apr 19, 2024
Closed
@Lovemore-Gakava Lovemore-Gakava linked a pull request May 3, 2024 that will close this issue
fix: added argument for baseline value. #144
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lovemore-Gakava Lovemore-Gakava

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

fix: added argument for baseline value. SafetyGraphics/nepExplorer
2 participants
@pburnsdata @Lovemore-Gakava