Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show "Set template as default" snackbar if template creation failed #279

Open
SUPERCILEX opened this issue Dec 29, 2019 · 0 comments
Labels
bug Something isn't working feature:templates Involves the scout template editor

Comments

@SUPERCILEX
Copy link
Owner

SUPERCILEX commented Dec 29, 2019

This requires #274. With the current architecture, fixing a bug like this is basically impossible.

Here's where things fail:

} catch (e: Exception) {
ref.delete().logFailures("addTemplate:delete", ref)
Dispatchers.Main { longToast(R.string.scout_add_template_not_cached_error) }
logBreadcrumb("addTemplate:getDefaultTemplate: ${defaultRef.path}")
throw InvocationMarker(e)
}

@SUPERCILEX SUPERCILEX added bug Something isn't working feature:templates Involves the scout template editor labels Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature:templates Involves the scout template editor
Projects
None yet
Development

No branches or pull requests

1 participant