Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Support #3

Open
p1nga opened this issue Nov 23, 2016 · 6 comments
Open

Plugin Support #3

p1nga opened this issue Nov 23, 2016 · 6 comments
Assignees

Comments

@p1nga
Copy link

p1nga commented Nov 23, 2016

I propose the it should be possible for the root path for the SCM could be a folder containing a .uplugin file as opposed to a .uproject file. This would open up a simpler way for people to manage working in multiple mods in a single project / SDK.

The user would be able to switch which plugin folder is currently integrated into the editor by changing some settings in the Source Control configuration box, and maybe a drop down to select a plugin folder that is connected to some SCM

@SRombauts
Copy link
Owner

Thanks for reporting this.

For future reference, bellow is the answer I gave on the UE forums :
https://forums.unrealengine.com/showthread.php?108688-Plastic-SCM-Source-Control-Provider

I am not entirely sure on how to do that:

  1. it would probably not be possible to add the auto-detection. I mean, I could try to check for a workspace in each plugin of the project (in GamePluginsDir()) but this could lead to multiple workspaces found, and it would not be what everyone whants
  2. would you accept a simple EditBox in the Connect to Source Control screen where you could change manually the path to the root of the project, to switch to a subdir?

@p1nga
Copy link
Author

p1nga commented Nov 27, 2016

I made a small change just for testing purpose, what i did was i hard coded the path to our plugin (on my local system) into the settings, and rebuilt from source, everything works just fine, i was going to look at making a check box, and drop down, but i'm not much of a c++ person.

@SRombauts
Copy link
Owner

Nice.
I believe I will work on it today or tomorrow, at least for à first simple version.

@p1nga
Copy link
Author

p1nga commented Dec 5, 2016

I modified the settings dialog to take a text input for the path to the workspace folder.
might be better if there is a dropdown with options to select a choice from automatic or plugin folder?
I also noticed that what ever i did broke the status icons, and that the path was cleared when you restart the editor. I'm no c++ programmer, so i was just messing about, but i was able to check out / in / sync as normal.
image

@SRombauts
Copy link
Owner

Sorry, I had not enough energy in spare to tackle seriously this last week!
What you did is great, but it's only half of the work: there are multiple parts in code that assume and rely on the root of the workspace being the root of the project.
I still hope to work on this "quite soon", stay tuned!

@SRombauts
Copy link
Owner

Hi @p1nga,

I have finally spend my evening on your feature request, I pushed 7ef75b2 on master!
It is not perfect but it seems working as intended, can you check it and let me know?

Cheers!

@SRombauts SRombauts self-assigned this Mar 13, 2017
@SRombauts SRombauts reopened this May 29, 2017
@SRombauts SRombauts removed the wontfix label May 30, 2017
SRombauts added a commit that referenced this issue Jun 30, 2017
SRombauts pushed a commit that referenced this issue Apr 12, 2022
Improve move/rename performances by using "cm mv --nomoveondisk"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants