Support for 5.4 on Mac

[Ratamorph]

I tried building it myself and it had a few simple compiler errors on some conditional code for Mac which I fixed, however the plugin doesn't seem to work well, it lets me connect but then when I try to do anything it tells me it's not connected and then I try to reconnect and it keeps going on that loop.

[SRombautsU]

Yep, it's a well known issue #1 OSX Build? and Mac support missing current working folder #88
I intend to try to fix it in the coming weeks!

Would you be able to provide the little compilation fixes
And perhaps the logs you got as well to help me start faster on the subject?

Many thanks
Sébastien

[Ratamorph]

That sounds great, here's the correct lines:

#elif PLATFORM_MAC
const char* PlasticExe = "/Applications/PlasticSCM.app/Contents/MacOS/macplasticx";
const char* GluonExe = "/Applications/Gluon.app/Contents/MacOS/macgluonx";
DesktopAppPath = FPlasticSourceControlModule::Get().GetProvider().IsPartialWorkspace() ? GluonExe : PlasticExe;

My compiler (Rider) was complaining about the variable definitions and suggested the change to const char*
There was also an extra closing parenthesis before de semicolon on the DesktopAppPath line.

I'll share logs next time I boot it up

[Ratamorph]

Here's some errors I get on the log

LogSourceControl: Error: RunCommand: 'checkconnection --server=OUR_SERVER' 'cm shell' stopped after 0.035s output (87 chars):
Error: The process cannot access the file because it is being used by another process.
SourceControl: Error: Command: UpdateStatus, Error: Error: The process cannot access the file because it is being used by another process.
LogSourceControl: UpdateStatus of 6603 items processed in 7.727s
LogSourceControl: Error: Command 'UpdateStatus' Failed!

[SRombautsU]

Thanks!
I think that the correct compilation fix is the commit 3bee755 that I have just pushed on https://github.com/SRombauts/UEPlasticPlugin/tree/fix-macos-compilation
In any case, the second issue will still need to be addressed, I'll work on it ASAP

[SRombauts]

Sorry, I didn't mean to close the issue, as I actually only fixed the compilation but I couldn't understand what is the issue with the underlying CLI