Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aspect ratio when video tracks don't provide resolution #500

Closed
MGaetan89 opened this issue Apr 17, 2024 · 0 comments · Fixed by #507
Closed

Fix aspect ratio when video tracks don't provide resolution #500

MGaetan89 opened this issue Apr 17, 2024 · 0 comments · Fixed by #507
Assignees
@MGaetan89
Labels
bug Something isn't working

Comments

@MGaetan89
Copy link
Member

As an integrator, I want to have access to the video aspect ratio, even if the video tracks don't provide the resolution.

Currently, the "Apple Basic 4:3" example doesn't display the video, even if it is playing.

Acceptance criteria

  • Video without resolution information in the tracks should be displayed
  • Aspect ratio is setup correctly when switching between videos having different ratios
  • Passing from video to audio or audio to video reset the display of the player
@MGaetan89 MGaetan89 converted this from a draft issue Apr 17, 2024
@MGaetan89 MGaetan89 added the bug Something isn't working label Apr 17, 2024
@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Apr 17, 2024
@MGaetan89 MGaetan89 self-assigned this Apr 17, 2024
@MGaetan89 MGaetan89 linked a pull request Apr 23, 2024 that will close this issue
Mitigate missing aspect ratio issue #507
Merged
6 tasks
@MGaetan89 MGaetan89 moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Apr 23, 2024
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MGaetan89 MGaetan89

Labels
bug Something isn't working
Projects
Pillarbox
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mitigate missing aspect ratio issue SRGSSR/pillarbox-android
1 participant
@MGaetan89